Fix(BREV-2215): Shadeform | Could not find refID error | when manually created instance has no tags#70
Merged
patelspratik merged 2 commits intomainfrom Jan 28, 2026
Merged
Conversation
harshsharmanv
changed the title
refID error | when manually created instance has no tags
| singleInstance, err := c.convertShadeformInstanceToV1Instance(instance) | ||
| if err != nil { | ||
| return nil, errors.WrapAndTrace(err) | ||
| continue |
Contributor
There was a problem hiding this comment.
seems like we would want an warn or err log line here so we can track these?
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, Prateek!
Added a warning log with instance ID, name, and error details to further track such instances.
patelspratik
previously approved these changes
Dec 19, 2025
jinendrajj
force-pushed
the
aditsharma55/BREV-2215
branch
from
bc1083a to
9450d25
Compare
patelspratik
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.